Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ints: stricter numbers #4939

Merged
merged 8 commits into from Jun 4, 2020
Merged

ints: stricter numbers #4939

merged 8 commits into from Jun 4, 2020

Commits on Jun 2, 2020

  1. proto: change int32 to uint32 (#4557) 

    * proto: change int32 to uint32

- address comments post merge from: #4332

proto goes down to int32/uint32 it does not provide a smaller size

* add contract to comment

* change to assertValues

* make funcs take uint32

* fix linting

* change equal to equalValues
    @tac0turtle
    tac0turtle committed Jun 2, 2020
    Copy the full SHA
    8988f3d View commit details
    Browse the repository at this point in the history

  2. stricter ints for round and valIndex (#4582) 

    * ints: change some ints to int32

- this is to help reduce the overall size of some proto prs.

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>

* add safemath for int32

* add safemath for subtraction

* add go doc to safemath funcs

* move panics to safe math, add checkconvert func

* make safe convert accept int64
    @tac0turtle
    tac0turtle committed Jun 2, 2020
    Copy the full SHA
    1ded104 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2020

  1. fix linter

    @tac0turtle
    tac0turtle committed Jun 3, 2020
    Copy the full SHA
    5b34aad View commit details
    Browse the repository at this point in the history

  2. remove signed message as type and fic changelog

    @tac0turtle
    tac0turtle committed Jun 3, 2020
    Copy the full SHA
    ddfe2e7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into marko/ints

    @tac0turtle
    tac0turtle committed Jun 3, 2020
    Copy the full SHA
    35bae8a View commit details
    Browse the repository at this point in the history

  4. fix test and linter

    @tac0turtle
    tac0turtle committed Jun 3, 2020
    Copy the full SHA
    daa126e View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2020

  1. Merge branch 'master' into marko/ints

    @tac0turtle
    tac0turtle committed Jun 4, 2020
    Copy the full SHA
    ae4557f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into marko/ints

    @tac0turtle
    tac0turtle committed Jun 4, 2020
    Copy the full SHA
    cd47711 View commit details
    Browse the repository at this point in the history