Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evidence: json tags for DuplicateVoteEvidence #4959

Merged
merged 2 commits into from Jun 4, 2020
Merged

Conversation

tac0turtle
Copy link
Contributor

Description

Add json tags to duplicate evidence

Closes: #4958

@auto-comment
Copy link

auto-comment bot commented Jun 4, 2020

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Wrote tests
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer
  • Applied Appropriate Labels

Thank you for your contribution to Tendermint! 🚀

@tac0turtle tac0turtle self-assigned this Jun 4, 2020
@tac0turtle tac0turtle added C:evidence Component: Evidence T:breaking Type: Breaking Change T:ux Type: Issue or Pull Request related to developer experience labels Jun 4, 2020
@tac0turtle tac0turtle marked this pull request as ready for review June 4, 2020 20:35
@tac0turtle tac0turtle changed the title evidence: json tags for duplicate evidence evidence: json tags for DuplicateVoteEvidence Jun 4, 2020
@tac0turtle tac0turtle added the S:automerge Automatically merge PR when requirements pass label Jun 4, 2020
@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #4959 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4959      +/-   ##
==========================================
+ Coverage   63.35%   63.38%   +0.03%     
==========================================
  Files         189      189              
  Lines       19583    19584       +1     
==========================================
+ Hits        12407    12414       +7     
+ Misses       6189     6184       -5     
+ Partials      987      986       -1     
Impacted Files Coverage Δ
libs/clist/clist.go 66.66% <0.00%> (-1.52%) ⬇️
blockchain/v2/reactor.go 35.35% <0.00%> (-1.28%) ⬇️
consensus/replay.go 71.72% <0.00%> (-1.27%) ⬇️
blockchain/v0/pool.go 78.98% <0.00%> (-0.32%) ⬇️
crypto/ed25519/encoding.go 100.00% <0.00%> (ø)
consensus/state.go 71.93% <0.00%> (+0.18%) ⬆️
consensus/reactor.go 73.77% <0.00%> (+1.74%) ⬆️

VoteA *Vote
VoteB *Vote
VoteA *Vote `json:"vote_a"`
VoteB *Vote `json:"vote_b"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks like we need also need to remove the pubkey field in the rust version too: https://github.com/informalsystems/tendermint-rs/pull/242/files#r417475910

@mergify mergify bot merged commit dc49dcc into master Jun 4, 2020
@mergify mergify bot deleted the 4958/add_jsontags branch June 4, 2020 22:41
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:evidence Component: Evidence S:automerge Automatically merge PR when requirements pass T:breaking Type: Breaking Change T:ux Type: Issue or Pull Request related to developer experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DuplicateVoteEvidence is missing JSON tags
3 participants