privval: allow passing options to NewSignerDialerEndpoint #5437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikgrinaker
requested review from
ebuchman,
tac0turtle,
melekes and
tessr
as code owners
tac0turtle
approved these changes
Oct 1, 2020
erikgrinaker
force-pushed
the
erik/rc5-5434
branch
from
f4fe8ef
to
44d2c00
Compare
Codecov Report
@@ Coverage Diff @@
## v0.34.0-rc5 #5437 +/- ##
==============================================
Coverage ? 61.42%
==============================================
Files ? 259
Lines ? 23421
Branches ? 0
==============================================
Hits ? 14386
Misses ? 7580
Partials ? 1455 |
Required for #5291 to set timeouts for remote signers.
erikgrinaker
force-pushed
the
erik/rc5-5434
branch
from
44d2c00
to
3fd051b
Compare
This was referenced Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5434.