Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockchain/v0: relax termination conditions and increase sync timeout #5741

Merged
merged 12 commits into from
Dec 8, 2020

Conversation

melekes
Copy link
Contributor

@melekes melekes commented Dec 3, 2020

Closes: #5718

@melekes melekes self-assigned this Dec 3, 2020
@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #5741 (c15b89c) into master (0d108ad) will decrease coverage by 0.16%.
The diff coverage is 63.36%.

@@            Coverage Diff             @@
##           master    #5741      +/-   ##
==========================================
- Coverage   60.48%   60.32%   -0.17%     
==========================================
  Files         259      259              
  Lines       23334    23345      +11     
==========================================
- Hits        14114    14083      -31     
- Misses       7754     7783      +29     
- Partials     1466     1479      +13     
Impacted Files Coverage Δ
blockchain/v2/io.go 0.00% <0.00%> (ø)
blockchain/v2/reactor.go 35.31% <33.33%> (+1.85%) ⬆️
blockchain/v0/reactor.go 63.96% <72.30%> (-0.57%) ⬇️
blockchain/v0/pool.go 77.18% <73.68%> (-1.79%) ⬇️
privval/signer_listener_endpoint.go 80.00% <0.00%> (-9.42%) ⬇️
privval/socket_listeners.go 78.72% <0.00%> (-4.26%) ⬇️
privval/secret_connection.go 72.68% <0.00%> (-3.61%) ⬇️
privval/signer_endpoint.go 75.75% <0.00%> (-3.04%) ⬇️
consensus/reactor.go 74.08% <0.00%> (-2.52%) ⬇️
... and 8 more

@melekes melekes marked this pull request as ready for review December 7, 2020 08:52
@melekes melekes changed the title blockchain/vX: ensure we switch to consensus after timeout blockchain/v0: relax termination conditions and increase sync timeout Dec 7, 2020
blockchain/v0/pool.go Outdated Show resolved Hide resolved
blockchain/v0/pool.go Outdated Show resolved Hide resolved
@melekes melekes merged commit 89e908e into master Dec 8, 2020
@melekes melekes deleted the anton/5718-blockchain-termination branch December 8, 2020 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

blockchain/vX: ensure we switch to consensus after timeout
3 participants