Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify Reactor priorities (#5826) #5830

Merged
merged 1 commit into from
Dec 23, 2020
Merged

modify Reactor priorities (#5826) #5830

merged 1 commit into from
Dec 23, 2020

Commits on Dec 23, 2020

  1. modify Reactor priorities (#5826)

    blockchain/vX reactor priority was decreased because during the normal operation
    (i.e. when the node is not fast syncing) blockchain priority can't be
    the same as consensus reactor priority. Otherwise, it's theoretically possible to
    slow down consensus by constantly requesting blocks from the node.
    
    NOTE: ideally blockchain/vX reactor priority would be dynamic. e.g. when
    the node is fast syncing, the priority is 10 (max), but when it's done
    fast syncing - the priority gets decreased to 5 (only to serve blocks
    for other nodes). But it's not possible now, therefore I decided to
    focus on the normal operation (priority = 5).
    
    evidence and consensus critical messages are more important than
    the mempool ones, hence priorities are bumped by 1 (from 5 to 6).
    
    statesync reactor priority was changed from 1 to 5 to be the same as
    blockchain/vX priority.
    
    Refs #5816
    melekes committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    2e64f1d View commit details
    Browse the repository at this point in the history