Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

light/provider/http: fix Validators #6022

Merged
merged 2 commits into from Feb 1, 2021
Merged

light/provider/http: fix Validators #6022

merged 2 commits into from Feb 1, 2021

Conversation

melekes
Copy link
Contributor

@melekes melekes commented Feb 1, 2021

Closes #6010

@melekes melekes self-assigned this Feb 1, 2021
@melekes melekes mentioned this pull request Feb 1, 2021
Closed
@codecov
Copy link

codecov bot commented Feb 1, 2021 •
edited

Codecov Report

Merging #6022 (116e143) into master (fc71882) will decrease coverage by 0.15%.
The diff coverage is 44.44%.

@@            Coverage Diff             @@
##           master    #6022      +/-   ##
==========================================
- Coverage   59.84%   59.68%   -0.16%     
==========================================
  Files         274      274              
  Lines       25240    25248       +8     
==========================================
- Hits        15105    15070      -35     
- Misses       8519     8554      +35     
- Partials     1616     1624       +8
Impacted Files Coverage Δ
types/validator_set.go 89.56% <0.00%> (-0.44%) ⬇️
light/provider/http/http.go 55.40% <50.00%> (-0.48%) ⬇️
privval/signer_listener_endpoint.go 80.00% <0.00%> (-9.42%) ⬇️
crypto/sr25519/pubkey.go 43.47% <0.00%> (-8.70%) ⬇️
types/tx.go 82.97% <0.00%> (-4.26%) ⬇️
privval/socket_listeners.go 78.72% <0.00%> (-4.26%) ⬇️
privval/secret_connection.go 72.68% <0.00%> (-3.61%) ⬇️
privval/signer_endpoint.go 75.75% <0.00%> (-3.04%) ⬇️
p2p/peer.go 47.91% <0.00%> (-2.66%) ⬇️
consensus/reactor.go 72.57% <0.00%> (-1.77%) ⬇️
... and 6 more

cmwaters
cmwaters approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@melekes
light/provider/http: iterate until total is reached
0fd9353 
also, restrict the number of pages to avoid iterating forever

Closes #6010

- rpc/client: change timeout type to be time.Duration in NewWithTimeout
- light/provider/http: set 5s timeout for all requests to avoid blocking forever
@melekes melekes force-pushed the anton/6010-light-client-validator-set branch from c075777 to 0fd9353 Compare February 1, 2021 11:15
@melekes melekes added the S:automerge Automatically merge PR when requirements pass label Feb 1, 2021
@mergify mergify bot merged commit 1cd9bdb into master Feb 1, 2021
@mergify mergify bot deleted the anton/6010-light-client-validator-set branch February 1, 2021 11:32
@colin-axner
Copy link

Will this be included in 0.34.4? Is there a place I can track this?

@cmwaters
Copy link
Contributor

cmwaters commented Feb 1, 2021

Yup we should backport this (@melekes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chengwenxi chengwenxi chengwenxi left review comments

@cmwaters cmwaters cmwaters approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@ebuchman ebuchman Awaiting requested review from ebuchman

@erikgrinaker erikgrinaker Awaiting requested review from erikgrinaker

@tessr tessr Awaiting requested review from tessr

@tac0turtle tac0turtle Awaiting requested review from tac0turtle

Assignees

@melekes melekes

Labels
S:automerge Automatically merge PR when requirements pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

light client cannot work when the number of validators is equal 100
4 participants
@melekes @colin-axner @cmwaters @chengwenxi