config/indexer: custom event indexing #6411

JayT106 · 2021-04-30T02:17:25Z

This PR is the ADR065 implementation
https://github.com/tendermint/tendermint/blob/master/docs/architecture/adr-065-custom-event-indexing.md
ref: #6303

codecov · 2021-05-05T19:32:02Z

Codecov Report

Merging #6411 (d500012) into master (692f23d) will increase coverage by 0.11%.
The diff coverage is 54.27%.

@@            Coverage Diff             @@
##           master    #6411      +/-   ##
==========================================
+ Coverage   60.73%   60.84%   +0.11%     
==========================================
  Files         289      292       +3     
  Lines       27212    27319     +107     
==========================================
+ Hits        16527    16623      +96     
- Misses       8990     9000      +10     
- Partials     1695     1696       +1

Impacted Files	Coverage Δ
config/toml.go	`59.09% <ø> (ø)`
rpc/core/blocks.go	`23.36% <0.00%> (-0.68%)`	⬇️
rpc/core/env.go	`47.05% <ø> (ø)`
rpc/core/tx.go	`0.00% <0.00%> (ø)`
state/indexer/indexer.go	`80.00% <ø> (ø)`
types/events.go	`100.00% <ø> (ø)`
state/indexer/indexer_service.go	`57.14% <52.38%> (+1.87%)`	⬆️
state/indexer/sink/psql/psql.go	`72.00% <72.00%> (ø)`
node/node.go	`51.77% <80.00%> (+2.00%)`	⬆️
node/setup.go	`70.43% <86.48%> (+1.77%)`	⬆️
... and 21 more

rpc/core/tx.go

alexanderbez

Great work @JayT106! Left some feedback 👍

config/config.go

node/node.go

state/indexer/sink/psql/schema.sql

state/indexer/tx/kv/kv_test.go

rpc/core/blocks.go

rpc/core/tx.go

state/indexer/indexer_service_test.go

state/indexer/sink/psql/psql_test.go

state/indexer/sink/psql/schema.sql

node/setup.go

state/indexer/sink/psql/schema.sql

… events

JayT106 requested review from alexanderbez, cmwaters, ebuchman, tessr and tychoish as code owners April 30, 2021 02:17

JayT106 changed the title ~~ADR065 custom event indexing (WIP)~~ state/indexer: custom event indexing (WIP) Apr 30, 2021

JayT106 changed the title ~~state/indexer: custom event indexing (WIP)~~ config/indexer: custom event indexing (WIP) Apr 30, 2021

tac0turtle marked this pull request as draft April 30, 2021 08:26

JayT106 force-pushed the adr065-custom-event-indexing branch 4 times, most recently from b069a4b to f315367 Compare May 5, 2021 19:25

JayT106 force-pushed the adr065-custom-event-indexing branch 3 times, most recently from c5db30e to f0a2ac4 Compare May 6, 2021 18:59

JayT106 changed the title ~~config/indexer: custom event indexing (WIP)~~ config/indexer: custom event indexing May 6, 2021

JayT106 marked this pull request as ready for review May 6, 2021 19:23

JayT106 force-pushed the adr065-custom-event-indexing branch 2 times, most recently from c91be22 to 62db29b Compare May 7, 2021 19:11

tac0turtle reviewed May 10, 2021

View reviewed changes

rpc/core/tx.go Outdated Show resolved Hide resolved

tac0turtle reviewed May 10, 2021

View reviewed changes

rpc/core/tx.go Outdated Show resolved Hide resolved

alexanderbez suggested changes May 10, 2021

View reviewed changes

JayT106 force-pushed the adr065-custom-event-indexing branch from 99acb7c to de570c8 Compare May 10, 2021 19:01

alexanderbez suggested changes May 11, 2021

View reviewed changes

JayT106 force-pushed the adr065-custom-event-indexing branch 3 times, most recently from 33a6aaf to 1b0a0c6 Compare May 12, 2021 19:56

alexanderbez reviewed May 12, 2021

View reviewed changes

node/setup.go Outdated Show resolved Hide resolved

state/indexer/sink/psql/schema.sql Show resolved Hide resolved

JayT106 force-pushed the adr065-custom-event-indexing branch from 96c3f31 to 230b7df Compare May 13, 2021 00:36

JayT106 added 25 commits May 26, 2021 17:00

revise the psql schema and test

6ef84b8

remove unused functions

0b62b62

make indexer.indexingEnabled public

d7bf4df

fix wording

c07ab44

remove TxIndexer.AddBatch

aad8d23

add eventSinks duplicate checks

21f425e

add timestampz in the psql schema

bb514b4

check duplicated sinks when creating the indexerService

f6fae3d

increase kvsink test coverage

147a80d

revise tx-index.indexer parser in template

4cf21fd

revise eventsink setup logic, add nullSink when the config is empty

648e636

fix wording

0073711

remove BlockSearch unreachable returns

e157b27

fix tx index error due to empty transaction

d6ff461

fix psql_test check logic and add more checks for verifying the block…

6d0ff0e

… events

add chain_id into the PSQL eventsink schema

66f0ec2

formatting

a2b4acf

revise the function indexBlockEvents arguments

cf2435d

update pending changelog

e336ef0

update ADR65 doc

bd73e04

update pending changelog

c99e41b

update dependency

81baad5

revise wording and logs level

ede398c

revise psql_test checks

3518b42

fix test error

035c116

JayT106 force-pushed the adr065-custom-event-indexing branch from 94b88ee to 035c116 Compare May 26, 2021 21:00

Merge branch 'master' into adr065-custom-event-indexing

d500012

tychoish approved these changes May 27, 2021

View reviewed changes

alexanderbez merged commit 711a718 into tendermint:master May 27, 2021

alexanderbez mentioned this pull request Aug 18, 2021

backport event fixes #6828

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

config/indexer: custom event indexing #6411

config/indexer: custom event indexing #6411

JayT106 commented Apr 30, 2021 •

edited

codecov bot commented May 5, 2021 •

edited

alexanderbez left a comment

config/indexer: custom event indexing #6411

config/indexer: custom event indexing #6411

Conversation

JayT106 commented Apr 30, 2021 • edited

codecov bot commented May 5, 2021 • edited

Codecov Report

alexanderbez left a comment

Choose a reason for hiding this comment

JayT106 commented Apr 30, 2021 •

edited

codecov bot commented May 5, 2021 •

edited