Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

state: move pruneBlocks from consensus/state to state/execution #6541

Merged
merged 4 commits into from
Jun 10, 2021

Conversation

JayT106
Copy link
Contributor

@JayT106 JayT106 commented Jun 4, 2021

state: move pruneBlocks function from consensus/state to state/execution

Closes #5414

Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this @JayT106 👍

Looking at this, it seems that we've changed the behaviour of fast sync. Prior it seems like there was no pruning whilst fast syncing but it looks like now there will be. I believe that's fine 🤔

@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #6541 (22b4996) into master (32bc399) will decrease coverage by 0.03%.
The diff coverage is 61.36%.

@@            Coverage Diff             @@
##           master    #6541      +/-   ##
==========================================
- Coverage   61.08%   61.04%   -0.04%     
==========================================
  Files         295      295              
  Lines       27850    27848       -2     
==========================================
- Hits        17011    17000      -11     
- Misses       9124     9130       +6     
- Partials     1715     1718       +3     
Impacted Files Coverage Δ
internal/blockchain/v2/processor_context.go 68.00% <0.00%> (ø)
internal/blockchain/v2/reactor.go 32.04% <ø> (ø)
internal/consensus/replay_file.go 0.00% <0.00%> (ø)
state/execution.go 66.19% <57.14%> (-0.85%) ⬇️
internal/blockchain/v0/reactor.go 65.21% <100.00%> (ø)
internal/consensus/replay.go 72.11% <100.00%> (ø)
internal/consensus/state.go 67.18% <100.00%> (+0.31%) ⬆️
internal/consensus/wal_generator.go 70.75% <100.00%> (ø)
node/node.go 51.77% <100.00%> (+0.07%) ⬆️
internal/consensus/peer_state.go 79.82% <0.00%> (-4.39%) ⬇️
... and 15 more

@tac0turtle tac0turtle added C:state Component: State S:automerge Automatically merge PR when requirements pass labels Jun 8, 2021
@mergify mergify bot merged commit a456b71 into tendermint:master Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:state Component: State S:automerge Automatically merge PR when requirements pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

state: block executor should handle block pruning
4 participants