pex: remove legacy proto messages #7147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmwaters
requested review from
creachadair,
ebuchman,
tychoish and
williambanfield
as code owners
tychoish
approved these changes
Oct 21, 2021
creachadair
reviewed
Oct 21, 2021
.gitignore
Outdated
| @@ -46,3 +46,4 @@ test/fuzz/**/corpus | |||
| test/fuzz/**/crashers | |||
| test/fuzz/**/suppressions | |||
| test/fuzz/**/*.zip | |||
| *.proto | |||
There was a problem hiding this comment.
We still have a bunch of other proto files in the repo, do we really want this at the top level?
There was a problem hiding this comment.
Right good catch. I will make it more granular
scripts/protocgen.sh
Outdated
| set -eo pipefail | ||
|
|
||
| VERS=master |
There was a problem hiding this comment.
Was the goal here to allow this to be set from the environment? If not, we don't really need the conditional stuff. Otherwise consider maybe:
Suggested change
| VERS=master | |
| : ${VERS:=master} |
…which would allow, e.g., VERS=blah ./scripts/protocgen.sh.
There was a problem hiding this comment.
It wasn't like that before, but this makes sense 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the proto changes made in tendermint/spec#352, removing the legacy messages that were used in the pex reactor.