config: expose ability to write config to arbitrary paths #7174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tychoish
requested review from
cmwaters,
creachadair,
ebuchman and
williambanfield
as code owners
creachadair
approved these changes
Oct 27, 2021
config/toml.go
Outdated
|
|
||
| // WriteConfig writes the config to the file specified by the path, | ||
| // and does not mangle the path or filename. | ||
| func WriteConfig(conf *Config, path string) error { |
There was a problem hiding this comment.
I feel like this needs a better name. It makes sense now, in context, but reading it later I know I'm going to get confused.
Perhaps: WriteConfigExactPath?
(I know, in a better world, this would be WriteConfigFile and we'd rename the old one to like WriteRootConfig or something, but we can't fix everything 🙂)
tychoish
added a commit
that referenced
this pull request
Oct 29, 2021
(cherry picked from commit 6108d0a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address many of the remaining concerns of #7149.