proto: update the mechanism for generating protos from spec repo #7269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tychoish
reviewed
Nov 10, 2021
williambanfield
requested review from
cmwaters,
creachadair and
ebuchman
as code owners
creachadair
reviewed
Nov 11, 2021
Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
creachadair
reviewed
Nov 13, 2021
creachadair
reviewed
Nov 13, 2021
| # Get shortened ref of commit | ||
| REF=$(curl -H "Accept: application/vnd.github.v3.sha" -qL \ | ||
| "https://api.github.com/repos/tendermint/spec/commits/${VERS}" \ | ||
| | cut -c -7) |
There was a problem hiding this comment.
Probably no real need to truncate the hash (though it is harmless).
There was a problem hiding this comment.
Oh, I see why you did that, because of the way the tarballer names its directory. ✔️
creachadair
reviewed
Nov 13, 2021
creachadair
approved these changes
Nov 15, 2021
williambanfield
added
the
S:automerge
tychoish
pushed a commit
to tychoish/tendermint
that referenced
this pull request
Nov 19, 2021
…dermint#7269) This pull request updates the `protocgen.sh` script to insert the `go_package` option to all of the downloaded proto files. A related pull request into the spec repo removes this options from the .proto files: tendermint/spec#358 This pull requests, along with the related spec PR, aim to move the creation of the `tendermintdev/docker-build-proto` container into the spec repo. This change also relies on several fixes to that container that are made in the PR into the spec repo.
creachadair
pushed a commit
that referenced
this pull request
Nov 19, 2021
This is a manual backport of the changes to how we build and run the protobuf toolchain images in Docker. The main effect here is to point to the new image from ghcr.io/tendermint/docker-proto-builder, but to make that work it is also necessary to update some of the branch pointers. This change does NOT include the changes from #7269 and #7291 to point to the proto files in the spec repo. To do that, we will need to create a branch or tag on the spec that has the released version, which does not exist in the spec history as it currently stands.
creachadair
pushed a commit
that referenced
this pull request
Nov 22, 2021
This is a manual backport of the changes to how we build and run the protobuf toolchain images in Docker. The main effect here is to point to the new image from ghcr.io/tendermint/docker-proto-builder, but to make that work it is also necessary to update some of the branch pointers. This change does NOT include the changes from #7269 and #7291 to point to the proto files in the spec repo. To do that, we will need to create a branch or tag on the spec that has the released version, which does not exist in the spec history as it currently stands.
lklimek
referenced
this pull request
in dashpay/tenderdash
Mar 25, 2022
This is a manual backport of the changes to how we build and run the protobuf toolchain images in Docker. The main effect here is to point to the new image from ghcr.io/tendermint/docker-proto-builder, but to make that work it is also necessary to update some of the branch pointers. This change does NOT include the changes from #7269 and #7291 to point to the proto files in the spec repo. To do that, we will need to create a branch or tag on the spec that has the released version, which does not exist in the spec history as it currently stands. (cherry picked from commit a97b081)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
protocgen.shscript to insert thego_packageoption to all of the downloaded proto files. A related pull request into the spec repo removes this options from the .proto files: tendermint/spec#358This pull requests, along with the related spec PR, aim to move the creation of the
tendermintdev/docker-build-protocontainer into the spec repo. This change also relies on several fixes to that container that are made in the PR into the spec repo.