Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pubsub: Report a non-nil error when shutting down. #7309

Merged
merged 2 commits into from
Nov 23, 2021
Merged

pubsub: Report a non-nil error when shutting down. #7309

merged 2 commits into from
Nov 23, 2021

Commits on Nov 23, 2021

  1. pubsub: Report a non-nil error when shutting down. 

    If a subscriber arrives while the pubsub service is shutting down, the existing
code will return a nil subscription without error. With unlucky timing, this
may lead to a nil indirection panic in the RPC service.

To avoid that problem, make sure that when a subscription fails for this
reason, we report a non-nil error so that the client will detect it and give up
gracefully.
    M. J. Fromberger committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    6ec9890 View commit details
    Browse the repository at this point in the history

  2. Update changelog.

    M. J. Fromberger committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    d84abbd View commit details
    Browse the repository at this point in the history