Fixing handling of contexts in the ABCI++ rebased branch #7768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergio-mena
requested review from
cmwaters,
creachadair,
ebuchman,
tychoish and
williambanfield
as code owners
sergio-mena
force-pushed
the
sergio/context-managment-fixes
branch
from
2dcdfc7
to
3b592ae
Compare
|
Just rebased on top of @creachadair's revert (thanks a lot BTW!) |
creachadair
approved these changes
Feb 3, 2022
williambanfield
approved these changes
Feb 3, 2022
tychoish
approved these changes
Feb 3, 2022
sergio-mena
force-pushed
the
sergio/context-managment-fixes
branch
from
3b592ae
to
2c249e1
Compare
tychoish
pushed a commit
to tychoish/tendermint
that referenced
this pull request
Feb 4, 2022
…7768) * Fixing context * Removed logger change * Fixing UTs * Bump
17 tasks
This was referenced Dec 19, 2022
sergio-mena
added a commit
that referenced
this pull request
Dec 22, 2022
…nch (#7768) * Fixing context * Removed logger change * Fixing UTs * Bump
This was referenced Dec 22, 2022
faddat
pushed a commit
to notional-labs/tendermint
that referenced
this pull request
Apr 3, 2023
…endermint#7768 (#7) * [cherry-picked] Fixing handling of contexts in the ABCI++ rebased branch (tendermint#7768) * Fixing context * Removed logger change * Fixing UTs * Bump * Fix build, make UTs pass * Thread contexts to the concerned test cases * Placate linter * Make TestCheckSwitchToConsensusLastHeightZero less flaky * bump * Update blocksync/reactor_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at the code belonging to
PrepareProposaland vote extensions, I saw some instances of functions that, rather than receiving a context and passing it along, they usecontext.Background()