WIP: abci++: Propagating vote extensions #8375
Conversation
thanethomson
force-pushed
the
sergio/8272-propagating-vote-extensions
branch
from
3981cec
to
4e6a556
Compare
| @@ -222,7 +223,7 @@ func (pool *BlockPool) PeekTwoBlocks() (first *types.Block, second *types.Block) | |||
| } | |||
|
|
|||
| // PopRequest pops the first block at pool.height. | |||
| // It must have been validated by 'second'.Commit from PeekTwoBlocks(). | |||
| // It must have been validated by 'second'.Commit from PeekTwoBlocks(), TODO: (?) and its corresponding ExtendedCommit. | |||
There was a problem hiding this comment.
This will be changed with the verification in any case. The verification will include vote extensions where applicable. But it is worth adding this comment here for reference.
There was a problem hiding this comment.
Yes, I'm aware that however strict we want to be with the current code, it won't be "enough" (as compared with the work @jmalicevic is doing).
That's why I'd propose to leave a comment if saying something like ("TODO: the first block should also be checked with the received extended commit")
There was a problem hiding this comment.
BTW, I have WIP draft PR for the changes so we are aware of what is going on: #8419.
| @@ -76,7 +76,7 @@ type Reactor struct { | |||
| stateStore sm.Store | |||
|
|
|||
| blockExec *sm.BlockExecutor | |||
| store *store.BlockStore | |||
| store sm.BlockStore | |||
There was a problem hiding this comment.
This is just for my understanding, why is the internal/store replaced with the store from internal/state?
There was a problem hiding this comment.
When I was navigating this code, I saw other places were using the blockstore interface, rather than the object directly... so I thought I'd change this for consistency... but I might be missing the bigger picture
This reverts commit 64f911a.
Signed-off-by: Thane Thomson <connect@thanethomson.com>
thanethomson
force-pushed
the
sergio/8272-propagating-vote-extensions
branch
from
4e6a556
to
246d3c2
Compare
|
Superseded by #8433. |
This follows on from #8141.