Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
abci++: Propagate vote extensions (RFC 017) #8433
abci++: Propagate vote extensions (RFC 017) #8433
Changes from 65 commits
d651cd5
98ea839
f18f1cb
23d4d6f
9cd356d
49a6b2f
bb4a1c7
adfdfca
82dd779
c5db2e9
dc6a208
fba6848
91d076a
4037fcd
61d5837
583d5fc
b3f3c32
5c81f7a
056aa98
656d2d0
ce70167
e503d74
6396abd
51f87b6
a327736
e3bfd43
1378900
421a12b
4aed18a
dd5c23d
2febbb2
a8adf63
86f942a
fce052d
1667ed2
0e8fc8e
9fcab60
b9fe2d7
24d1e6d
a3b3415
b5a94bb
59434d8
386cdef
0a31afe
d0102e6
2ef2733
3377d61
c9deedf
6a69e88
bce2c7c
a20a485
408cc4c
e43e72c
0dd7ce3
630ec25
accba47
08bf156
a27365b
e7e7da3
5217349
739e60e
fe5220b
6389f2f
595377f
9483b42
b1896eb
db91461
2cbaa35
8922ae4
d688cf0
ecb523c
7b1f36d
20fadb6
d53d11d
4f5f158
8cc7776
acb3723
2668f19
a0742ce
e000d1c
68013b8
15220bb
d90b0f3
2146a7f
6fffbf9
af51493
76e36fc
585ba6a
efd1313
c278eb1
84bf76e
74ddd7a
aa7fbc8
9350ceb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The light client verification doesn't rely on the extended commits, so I don't see this being necessary. Maybe I'm missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The point of that TODO is that, now, we have two commits we can use for verification:
second
first
So we could be extra-careful and validate against both, by calling
VerifyCommitLight
twice: once with each commit that we have. This is for the über-anxious like myself :-)I would like to have @jmalicevic's input here, as she's the one really looking into this aspect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@williambanfield are you saying that we do not really care about whether the extended commit provided to us passes validation as we will not need it? If so, if this block is the last one before we switch to consensus, we do want to verify it, no? If you agree with my first sentence, then maybe it is not necessary to verify every extended commit but I somehow feel we do want to verify it before switching back to consensus (except, right now we do not now this at the point of verification here, so we'd have to introduce a check elsewhere).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! I see, then I misunderstood. I was thinking this meant we should use the
ExtendedCommit
to validate the header, (which didn't seem necessary since we already do the call toVerifyLightCommit
) but it seems like the intent is sort of the reverse, use the validated header (andLastCommit
) to ensure that theExtendedCommit
is correct. That seems great to me.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmalicevic, would you agree on taking on this TODO on your side? (which also means deciding how to tackle it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sergio-mena sure, I think it makes sense to include it as part of the verification work