Add public API BlockStore.Rollback

[yihuang]

The context: #8223 (comment), #8493

So although the newest tendermint has implemented the "validate block before persist", but since the production node could be still using the old version, and when app hash mismatch happens, the pending block is already persisted, so we still want to be able to delete that pending block manually.
By exposing this public API, we can do the block store rollback in the application side.

[cmwaters]

but since the production node could be still using the old version, and when app hash mismatch happens

We did backport these changes to v0.34. I just don't think we've cut a point release yet

[yihuang]

but since the production node could be still using the old version, and when app hash mismatch happens

We did backport these changes to v0.34. I just don't think we've cut a point release yet

Since the current production nodes are running with old versions, and even if we release a new patch version, they don't necessarily all upgrade in time, so I think it's good to support an optional --delete-pending-block flag in the rollback command in cosmos-sdk (only in 0.45). For example, we already have a case at hand, where there's a pending block, without this functionality, we need to create some ad-hoc tool to delete that pending block anyway (it also needs a public API for convenience, otherwise we need to deal with the raw keys).

[cmwaters]

By pending block you mean a block that has been committed but hasn't been executed yet?

[yihuang]

By pending block you mean a block that has been committed but hasn't been executed yet?

Yeah, more specifically, it's in the block store, but not state store.
To make sure we can rollback a block in state, we have to delete that block in block store.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[yihuang]

don't stale

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.