e2e: fix out of sync configuration #9199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thanethomson
approved these changes
Aug 9, 2022
samricotta
pushed a commit
that referenced
this pull request
Aug 10, 2022
The v0.34.x tests have been failing (or reporting failures, I don't believe that this is a real failure,) because the CI configuration has been out of sync with itself, likely due to a mistake during backporting configs from the `master` branch. The entire 0.34.x e2e test suite takes 26 minutes to run, plus about 7 minutes to build the docker image. Each split has to build the same docker image, (and is therefore a cap on the amount of parallelism we can get at the moment.) Having more groups, just seems like we'll be burning money building the docker image with no really meaningful difference in throughput. For a nightly test that people don't really wait on, the current latency (time-to-completion) of roughly 19 minutes, isn't causing in friction.
samricotta
pushed a commit
that referenced
this pull request
Aug 11, 2022
The v0.34.x tests have been failing (or reporting failures, I don't believe that this is a real failure,) because the CI configuration has been out of sync with itself, likely due to a mistake during backporting configs from the `master` branch. The entire 0.34.x e2e test suite takes 26 minutes to run, plus about 7 minutes to build the docker image. Each split has to build the same docker image, (and is therefore a cap on the amount of parallelism we can get at the moment.) Having more groups, just seems like we'll be burning money building the docker image with no really meaningful difference in throughput. For a nightly test that people don't really wait on, the current latency (time-to-completion) of roughly 19 minutes, isn't causing in friction.
samricotta
pushed a commit
that referenced
this pull request
Aug 11, 2022
The v0.34.x tests have been failing (or reporting failures, I don't believe that this is a real failure,) because the CI configuration has been out of sync with itself, likely due to a mistake during backporting configs from the `master` branch. The entire 0.34.x e2e test suite takes 26 minutes to run, plus about 7 minutes to build the docker image. Each split has to build the same docker image, (and is therefore a cap on the amount of parallelism we can get at the moment.) Having more groups, just seems like we'll be burning money building the docker image with no really meaningful difference in throughput. For a nightly test that people don't really wait on, the current latency (time-to-completion) of roughly 19 minutes, isn't causing in friction.
samricotta
pushed a commit
that referenced
this pull request
Aug 12, 2022
The v0.34.x tests have been failing (or reporting failures, I don't believe that this is a real failure,) because the CI configuration has been out of sync with itself, likely due to a mistake during backporting configs from the `master` branch. The entire 0.34.x e2e test suite takes 26 minutes to run, plus about 7 minutes to build the docker image. Each split has to build the same docker image, (and is therefore a cap on the amount of parallelism we can get at the moment.) Having more groups, just seems like we'll be burning money building the docker image with no really meaningful difference in throughput. For a nightly test that people don't really wait on, the current latency (time-to-completion) of roughly 19 minutes, isn't causing in friction.
samricotta
pushed a commit
that referenced
this pull request
Aug 16, 2022
The v0.34.x tests have been failing (or reporting failures, I don't believe that this is a real failure,) because the CI configuration has been out of sync with itself, likely due to a mistake during backporting configs from the `master` branch. The entire 0.34.x e2e test suite takes 26 minutes to run, plus about 7 minutes to build the docker image. Each split has to build the same docker image, (and is therefore a cap on the amount of parallelism we can get at the moment.) Having more groups, just seems like we'll be burning money building the docker image with no really meaningful difference in throughput. For a nightly test that people don't really wait on, the current latency (time-to-completion) of roughly 19 minutes, isn't causing in friction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v0.34.x tests have been failing (or reporting failures, I don't
believe that this is a real failure,) because the CI configuration has
been out of sync with itself, likely due to a mistake during
backporting configs from the
masterbranch.The entire 0.34.x e2e test suite takes 26 minutes to run, plus about 7
minutes to build the docker image. Each split has to build the same
docker image, (and is therefore a cap on the amount of parallelism we
can get at the moment.) Having more groups, just seems like we'll be
burning money building the docker image with no really meaningful
difference in throughput. For a nightly test that people don't really
wait on, the current latency (time-to-completion) of roughly 19
minutes, isn't causing in friction.