Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: backport the rename of fastsync to blocksync #9259

Merged
merged 15 commits into from
Aug 17, 2022
Merged

Conversation

williambanfield
Copy link
Contributor

@williambanfield williambanfield commented Aug 15, 2022

This is largely a cherry pick of #6755 with some additional fixups added where detected.
This change moves the blockchain package to a package called blocksync. Additionally, it renames the relevant uses of the term fastsync to blocksync.

closes: #9227

PR checklist

  • Tests written/updated, or no tests needed
  • CHANGELOG_PENDING.md updated, or no changelog entry needed
  • Updated relevant documentation (docs/) and code comments, or no
    documentation updates needed

@williambanfield williambanfield changed the title backport fastsync -> blocksync config: backport the rename of fastsync to blocksync Aug 16, 2022
@williambanfield williambanfield marked this pull request as ready for review August 16, 2022 18:40
@williambanfield williambanfield requested review from a team August 16, 2022 18:40
@cmwaters
Copy link
Contributor

The config.toml is breaking right? say I had "v1" selected in v0.34. v0.37 won't correctly read it and think that it's not set and thus use the default ("v0"). I'm not sure how much of a problem this is as we've deprecated all the other options. In v0.37 we're essentially forcing everyone to use "v0".

@williambanfield
Copy link
Contributor Author

williambanfield commented Aug 17, 2022

It will read it correctly, it will just error:

case "v1", "v2":

EDIT:

I see what you're saying: the name of the toml table changed to [blocksync] so old configs will automatically get the default values because the table will not be set. I'll add a lot statement so that operators know to update.

@cmwaters
Copy link
Contributor

Yeah this would be something that an automated migration set up would be able to handle. I think a warning in the logs upon start up makes sense

@williambanfield williambanfield self-assigned this Aug 17, 2022
@williambanfield williambanfield added C:config S:automerge Automatically merge PR when requirements pass labels Aug 17, 2022
@mergify mergify bot merged commit 1069ffc into main Aug 17, 2022
@mergify mergify bot deleted the wb/issue-9227 branch August 17, 2022 15:19
cmwaters pushed a commit that referenced this pull request Aug 19, 2022
This is largely a cherry pick of #6755 with some additional fixups added where detected. 
This change moves the blockchain package to a package called blocksync. Additionally, it renames the relevant uses of the term `fastsync` to `blocksync`.

closes: #9227 

#### PR checklist

- [ ] Tests written/updated, or no tests needed
- [x] `CHANGELOG_PENDING.md` updated, or no changelog entry needed
- [x] Updated relevant documentation (`docs/`) and code comments, or no
      documentation updates needed
@williambanfield williambanfield restored the wb/issue-9227 branch September 9, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:config S:automerge Automatically merge PR when requirements pass
Projects
Status: Done/Merged
Development

Successfully merging this pull request may close these issues.

blockchain: Port renaming of fastsync to blocksync to main
3 participants