Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

abci: Remove SetOption #5447 #9091 #9266

Merged
merged 7 commits into from
Aug 16, 2022
Merged

abci: Remove SetOption #5447 #9091 #9266

merged 7 commits into from
Aug 16, 2022

Conversation

samricotta
Copy link
Contributor

Moving the changes from issue #5447 into main. This PR removes theResponse/Request SetOption from ABCI replicated from #5447

Note: This is part of the ABCI++ Prepare/Process Proposal Release Plan #9091

@samricotta samricotta requested a review from a team August 16, 2022 10:16
@samricotta samricotta changed the title bci: Remove SetOption #5447 #9091 abci: Remove SetOption #5447 #9091 Aug 16, 2022
cmwaters
cmwaters approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@cmwaters cmwaters left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Probably a good idea to add a changelog entry as well

tychoish
tychoish approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@tychoish tychoish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change logs should be good.

I think this is pretty unobjectionable and since this isn't used and we're already breaking abci a bit for this, it's fine.

@samricotta samricotta added backlog-priority A priority issue in the backlog priority A high-priority, high-level item to be shown on the priorities project board labels Aug 16, 2022
@thanethomson thanethomson removed the priority A high-priority, high-level item to be shown on the priorities project board label Aug 16, 2022
@samricotta samricotta merged commit 9993514 into feature/abci++ppp Aug 16, 2022
@samricotta samricotta deleted the remove-setoption branch August 16, 2022 20:58
@thanethomson thanethomson removed the backlog-priority A priority issue in the backlog label Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tychoish tychoish tychoish approved these changes

@cmwaters cmwaters cmwaters approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

Assignees
No one assigned
Labels
None yet
Projects
Tendermint
Status: Done/Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@samricotta @tychoish @cmwaters @thanethomson