Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: bump module versions #9739

Closed
wants to merge 12 commits into from
Closed

build: bump module versions #9739

wants to merge 12 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Nov 22, 2022 •
edited
Loading

This PR gives go.mod some love:

  • separate imports into direct and indirect (if grouping before was intentional, we should note that in commments)
  • use the latest release of btcd's eliptic curve libraries

Note

This is pretty minor, so I haven't added a changelog entry.

PR checklist

  • Tests written/updated, or no tests needed
  • CHANGELOG_PENDING.md updated, or no changelog entry needed
  • Updated relevant documentation (docs/) and code comments, or no
    documentation updates needed

@faddat faddat requested a review from a team November 22, 2022 07:06
@faddat faddat changed the title group imports and bump tmdb and btcd eliptic curves maintain go.mod Nov 22, 2022
@faddat faddat changed the title maintain go.mod chore: maintain go.mod Nov 22, 2022
@faddat faddat changed the title chore: maintain go.mod build: maintain go.mod Nov 22, 2022
@faddat faddat changed the title build: maintain go.mod bump module versions and use only a single kv store Nov 22, 2022
@faddat faddat changed the title bump module versions and use only a single kv store build: bump module versions Nov 22, 2022
@faddat faddat mentioned this pull request Nov 22, 2022
Merged
3 tasks
@faddat
Copy link
Contributor Author

faddat commented Nov 23, 2022

erm, I suspect this one is a bit of a mess. Sorry about that!

@faddat faddat closed this Nov 23, 2022
mergify bot pushed a commit that referenced this pull request Nov 24, 2022
@faddat
make format (#9744)
8fd66a6 
## NOTE: this pr exclusively runs commands from the makefile found here


This PR ONLY runs `make format` ... then `make mockery`



Its purpose is to ensure that the review scope of other PR's, which changed .go files and thus triggered the linter that only runs conditionally, have smaller review 
scopes, and should be merged before:

#9738
#9739
#9742






---

#### PR checklist

- [x] Tests written/updated, or no tests needed
- [x] `CHANGELOG_PENDING.md` updated, or no changelog entry needed
- [x] Updated relevant documentation (`docs/`) and code comments, or no
      documentation updates needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebuchman ebuchman Awaiting requested review from ebuchman

@adizere adizere Awaiting requested review from adizere

@lasarojc lasarojc Awaiting requested review from lasarojc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@faddat