cleveldb: fix handling of empty iterator keys #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
erikgrinaker
changed the title
|
@melekes Changed this to only fix the iterator bug, while I make a new PR for closed batch errors. Could you review again please? |
melekes
approved these changes
Mar 10, 2020
erikgrinaker
force-pushed
the
erik/cleveldb-fixes
branch
from
599f99d
to
8e1f9b7
Compare
nddeluca
referenced
this pull request
in Kava-Labs/tm-db
Jan 8, 2024
* Fix lints Signed-off-by: Thane Thomson <connect@thanethomson.com> * Bump minimum Go version to 1.20 Signed-off-by: Thane Thomson <connect@thanethomson.com> * Install gcc 11 --------- Signed-off-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: lasarojc <lasaro@informal.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New tests showed that empty iterator keys causes panics.