This repository has been archived by the owner on Jun 3, 2020. It is now read-only.
Update all signatory dependencies to v0.11 (and 2018 edition fixups)
#170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My plan for landing this would be to release new versions of Signatory first (which are basically ready to go), and then update this PR to use them. |
tarcieri
commented
Feb 7, 2019
tarcieri
commented
Feb 7, 2019
tarcieri
commented
Feb 7, 2019
tarcieri
commented
Feb 7, 2019
tarcieri
commented
Feb 7, 2019
tarcieri
commented
Feb 7, 2019
tarcieri
commented
Feb 7, 2019
tarcieri
commented
Feb 7, 2019
tarcieri
commented
Feb 7, 2019
liamsi
reviewed
Feb 7, 2019
|
What is the status on this PR? I am looking into integrating the Ledger application into the KMS. |
|
Still blocked on a Signatory release, but I've finished up the remaining issues and should be able to cut a release tomorrow along with landing this PR. |
tendermint/signatory#139 Additionally it looks like there were various parts of the 2018 edition upgrade which were incomplete, and in order to get everything to build this completes that upgrade. This unfortunately makes it a bit of a mega-commit.
tarcieri
force-pushed
the
signatory-update
branch
from
3a91efb
to
774b137
Compare
tarcieri
changed the title
signatory dependencies to v0.11 (and 2018 edition fixups)
|
This should be ready to merge |
liamsi
approved these changes
Feb 13, 2019
tmkms now requires the 2018 edition of Rust
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates everything to the
as-yet-unreleasednew Signatory version (which will bev0.11).Additionally it looks like there were various parts of the 2018 edition upgrade which were incomplete, and in order to get everything to build this completes that upgrade. This unfortunately makes it a bit of a mega-commit. I could try to split things out but I ran into various broken dependencies either way trying to do things piecemeal.
All that said, this will hopefully be the last mega-upgrade of this nature required (famous last words).