This repository has been archived by the owner on Jun 3, 2020. It is now read-only.
Log all signature events at INFO level #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and improve logging at the debug level in general. Previously the KMS logged no information about what it signed at the default loglevel (INFO). To get that information, you had to log at the DEBUG level. This adds short loglines at the INFO level. They contain the chain ID, signed message type (proposal, prevote, precommit), and block height. Additionally, at the debug level it now prints debug messages containing the complete incoming request and response.
|
@liamsi this might be good for you to review (I might merge it anyway to get another alpha release out I can test), since it touches some of the amino code. I've tried to do it in the least invasive way possible which, if I did everything right, adds no new runtime error potential, so I'm not too worried. |
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and improve logging at the debug level in general.
Previously the KMS logged no information about what it signed at the default loglevel (INFO). To get that information, you had to log at the DEBUG level.
This adds short loglines at the INFO level. They contain the chain ID, signed message type (proposal, prevote, precommit), and block height.
Additionally, at the debug level it now prints debug messages containing the complete incoming request and response.