This repository has been archived by the owner on Jul 15, 2018. It is now read-only.
make TagMap's value string, not interface #204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #204 +/- ##
==========================================
+ Coverage 63.56% 63.8% +0.24%
==========================================
Files 61 61
Lines 4830 4813 -17
==========================================
+ Hits 3070 3071 +1
+ Misses 1535 1515 -20
- Partials 225 227 +2
Continue to review full report at Codecov.
|
zramsay
approved these changes
Apr 25, 2018
ebuchman
reviewed
Apr 26, 2018
| @@ -5,6 +5,8 @@ | |||
| FEATURES: | |||
|
|
|||
| - [common] ASCIITrim() | |||
| - [pubsub] TagMap#Get returns a string value | |||
| - [pubsub] NewTagMap accepts a map of strings | |||
There was a problem hiding this comment.
these changes are technically breaking
4 tasks
melekes
added a commit
to tendermint/tendermint
that referenced
this pull request
May 28, 2018
melekes
added a commit
to tendermint/tendermint
that referenced
this pull request
May 28, 2018
melekes
added a commit
to tendermint/tendermint
that referenced
this pull request
May 28, 2018
* expect all tags to be strings Refs #1369 * port changes from tendermint/tmlibs#204 Refs #1369
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs tendermint/tendermint#1369