Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rails-assets says jquery.layout has no versions but it seems to have #105

Closed
rosenfeld opened this issue Jan 23, 2014 · 8 comments
Closed

Comments

@rosenfeld
Copy link

"jquery.layout has no versions defined. Please create an issue in component's repository."

https://github.com/jlbfalcao/jquery.layout/blob/master/bower.json#L3

I don't quite understand the issue, would you mind to further explain it?

@sheerun
Copy link
Contributor

sheerun commented Jan 24, 2014

Bower reads versions from tags on GitHub. Version in bower.json actually doesn't much matter.

https://github.com/jlbfalcao/jquery.layout/releases

The only release in jquery.layout is non-semver one, and bower doesn't accept such versions.

Is it clear now?

@rosenfeld
Copy link
Author

Sure, thank you!

@rosenfeld
Copy link
Author

Just to be sure: http://semver.org/spec/v2.0.0.html
Is the problem the fact that it's not a proper hyphen in the version? I mean, would the version below be valid?

"1.3.0-rc30.79"

I'd like to know what exactly to ask to the repo maintainer...

@rosenfeld rosenfeld reopened this Jan 24, 2014
@sheerun
Copy link
Contributor

sheerun commented Jan 24, 2014

Hmm. Actually this is correct semver, but prerelease one. Rails Assets doesn't accept prerelease versions. The issue with jquery.layout is each version should have corresponding semver tag on GitHub (x.y.z)

@rosenfeld
Copy link
Author

But this is a problem in the case of jQuery layout as it seems it won't release any non-pre release for a long time and the last stable release is not compatible with newer jQuery... Could this requirement be changed on the rails-assets side?

@rosenfeld
Copy link
Author

http://layout.jquery-dev.net/downloads.cfm

"Despite being a 'release candidate', the 1.3.0 RC version is more bug-free and robust than 1.2.0. Plus it has many new options and features."

This message has been there forever... Unfortunately there's no official repository for this useful plugin and the repo above is just an attempt to integrate it to bower. It would be very helpful for us to be able to use it through bower without having to create fake official non-pre releases...

@sheerun
Copy link
Contributor

sheerun commented Jan 24, 2014

@rosenfeld From www we allow for compiling even prerelease versions: https://rails-assets.org/components/new You just need to specify component name and existing bower version.

Observe that bower returns no versions for this component:

bower info jquery.layout
bower jquery.layout#*           cached git://github.com/jlbfalcao/jquery.layout.git#ab39ea2748
bower jquery.layout#*         validate ab39ea2748 against git://github.com/jlbfalcao/jquery.layout.git#*

{
  name: 'jquery.layout',
  authors: [
    'Fabrizio Balliano',
    'Kevin Dalman'
  ],
  main: [
    'dist/jquery.layout-latest.js',
    'dist/layout-default-latest.css'
  ],
  description: 'UI Layout – The Ultimate Page Layout Manager',
  license: 'GPL and MIT',
  homepage: 'http://layout.jquery-dev.net/index.cfm',
  dependencies: {
    'jquery-ui': '*',
    jquery: '*'
  },
  ignore: [
    'README.md'
  ]
}

No versions available.

It's probably bower issue it doesn't accept this git tag.

In general we allow for compilation of any version returned from bower info <component>, so if you'll find a way to make 1.3.0–rc30.79 be listed there, Rails Assets should just work.

I think you should hit bower with this version issue or create fork with proper version tag by yourself.

@rosenfeld
Copy link
Author

Thank you. I'll investigate if this is just a character issue with the hyphen and see what we can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants