isolated parseHeader into own function

tenorviol · Jul 1, 2011 · f6aa8bf · f6aa8bf
1 parent 70c2b68
commit f6aa8bf
Showing 1 changed file with 18 additions and 12 deletions.
diff --git a/lib/mongodb-socket.js b/lib/mongodb-socket.js
@@ -22,27 +22,33 @@ function createServer(callback) {
 
 
 function parseMessage(data) {
-  var message = {
-    header : {}
-  };
+  var message = {};
+
   var offset = 0;
-  message.header.messageLength = BinaryParser.toInt(data.substr(offset, 4));
-  offset += 4;
-  message.header.requestID = BinaryParser.toInt(data.substr(offset, 4));
-  offset += 4;
-  message.header.responseTo = BinaryParser.toInt(data.substr(offset, 4));
-  offset += 4;
-  message.header.opCode = BinaryParser.toInt(data.substr(offset, 4));
-  offset += 4;
+  var header = message.header = parseHeader(data, offset);
+  offset += 16;
 
-  switch (message.header.opCode) {
+  switch (header.opCode) {
     case 2004:
       return parseQuery(message, data, offset);
   }
 
   return message;
 }
 
+function parseHeader(data, offset) {
+  var header = {};
+  header.messageLength = BinaryParser.toInt(data.substr(offset, 4));
+  offset += 4;
+  header.requestID = BinaryParser.toInt(data.substr(offset, 4));
+  offset += 4;
+  header.responseTo = BinaryParser.toInt(data.substr(offset, 4));
+  offset += 4;
+  header.opCode = BinaryParser.toInt(data.substr(offset, 4));
+  offset += 4;
+  return header;
+}
+
 function parseQuery(message, data, offset) {
   message.flags = BinaryParser.toInt(data.substr(offset, 4));
   offset += 4;