-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arguments broken #102
Comments
I cannot reproduce: $ git switch master
Already on 'master'
Your branch is up to date with 'upstream/master'.
$ git pull upstream
Already up to date.
$ git clean -dxf # make this as clean as it gets
Removing ttyplot
$ make
cc -Wall -Wextra ttyplot.c `pkg-config --libs ncurses 2>/dev/null || echo '-lcurses -ltinfo'` -o ttyplot
$ ./ttyplot -v
ttyplot 1.5.1
$ ./ttyplot -h
Usage:
ttyplot [-h] [-v] [-2] [-r] [-c plotchar] [-s scale] [-m max] [-M min] [-t title] [-u unit]
-2 read two values and draw two plots, the second one is in reverse video
[snip]
$ seq 1 80 | ./ttyplot -c o
# A plot is displayed with the ‘o’ character.
$ lsb_release -ds
Ubuntu 22.04.3 LTS |
I can't reproduce either,
Works great! |
@tenox7 can you define broken and share more about the environment? E.g. is it a box with ancient broken getopt by any chance? |
It could be that |
@tenox7 (and everyone else): Could you check if this MR works for you? If yes, I also incremented the version numbers for a hotfix release. |
haha, no the issue is on latest freebsd and macos; build from head master and ran with -2, still only shows one chart, -c and others do not work |
tried https://github.com/MIvanchev/ttyplot/tree/issue-102-potentially-incorrect-usage still same issue, both freebsd and macos |
@tenox7 OK, I know what the issue is, stand by. |
thank you :) |
@tenox7 Try now? I've added some BSD and Mac logic. |
checking (thank you!) |
same repo? just did linux: works |
git clone --branch |
wait I guess I forgot to switch the branch |
ok branch linux: works thank you! please send a PR |
It's here #103, good thing you test on non Linuxes :)) P.S. P.S.S. |
thank you for fixing @MIvanchev much appreciated!!!! |
NP, this is a small one, much more work to be done. |
FYI pull request Homebrew/homebrew-core#154651 by @Porkepix will get 1.5.2 with the fix into homebrew for macOS. OpenBSD with current 1.5.1 is also affected. Is anyone in touch with them on the topic already? |
@fcambus any chance you could bump ttyplot to 1.5.2 to fix issue #102 (comment) for users of OpenBSD? |
I just committed an update, thanks for the heads-up! |
@fcambus excellent, thank you! 👍 |
paging @MIvanchev #90 broke aruments/flags (update: for bsd/macos only), can you please fix?
The text was updated successfully, but these errors were encountered: