Add clipping char option (-C) #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent. I would make it a default as the current behavior is pretty lame. Could you make it default to 'x' for example? |
This switches to a different character to highlight values that have exceeded the user-defined max value (-m <max_value>). The original implementation just prints a blank bar; we now default to highlighting with 'x'.
gromgit
force-pushed
the
highlight_hardmax
branch
from
684a963
to
ba208bd
Compare
Done. I've updated this PR accordingly. |
|
Awesome thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches to a different character to highlight values that have
exceeded a user-defined max value. The original implementation just
leaves a blank line instead, which is ambiguous but may be desired
in various applications.