-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented hardmin feature #47
Conversation
Very nice! However you have also made some changes that do not concern hardmin feature. This makes it hard to read. Please split this PR in to smaller ones so that they can be addressed in a more granular meaner. Thank you! |
Done. Now all changes strictly concern with hardmin. |
I would also like the other changes, just in a separate PR. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting this. Works mostly awesome except the weird softmin issue and the usage/manual could use some improvement.
I agree, I was sloppy about the Regarding the And as to the error response of value being less than |
Hi, why did you close this? I would really like to get min/hardmin in to ttyplot. |
Hi, the PR was in the open state for quite some time, without any response. So, I decided to close it. |
I really want to have it so I guess reopen it? |
Thanks for the interest. |
thanks! let me try it! |
Merged thank you very much! |
Implemented the hardmin feature, as requested in issue #42 and issue #22 , along with other minor improvements.
softmin not implemented.