-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated features and FutureWarnings #239
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jakob-Unfried
changed the title
Future warnings
Remove deprecated features and FutureWarnings
Apr 27, 2023
Jakob-Unfried
force-pushed
the
future_warnings
branch
2 times, most recently
from
April 27, 2023 14:54
9104648
to
aabe755
Compare
Jakob-Unfried
force-pushed
the
future_warnings
branch
14 times, most recently
from
May 2, 2023 14:11
5734a06
to
6eea83c
Compare
@jhauschild There is a deprecation notice in the docstring of models.CouplingModel.add_coupling: Lines 1008 to 1009 in 8c8e8db
I am not sure why those arguments should be removed? Also, we have not issued warnings so far, so just removing the args would be quite harsh. |
Jakob-Unfried
force-pushed
the
future_warnings
branch
2 times, most recently
from
May 2, 2023 16:50
f53f050
to
f7abfca
Compare
Jakob-Unfried
force-pushed
the
future_warnings
branch
2 times, most recently
from
July 17, 2023 20:05
96129a1
to
e8d56e5
Compare
They have moved to mps_common.py
Jakob-Unfried
force-pushed
the
future_warnings
branch
from
March 18, 2024 19:24
b6ecfbf
to
0939db3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing support for deprecated features, FutureWarnings, etc.
I am heavily using rebase and force push on this branch, to get a clean commit history.
If you want to base anything on the commits in this branch, let me know, so i can be considerate of your history...
Wait with merging!
Should wait for all other features of release
1.0
, then release a version0.99
which includes all those features but still hast the FutureWarnings and backwards compatibilities.Then we merge this PR on top of
0.99
to release1.0
.Plan
FutureWarning
.. deprecated ::
Config.deprecated_alias
v1.0.0.rst
fileTODO list / single issues:
FutureWarning
filtering in the tests, e.g. in test_np_conserved.py viawarnings.simplefilter("ignore", FutureWarning)
still intended? (also in test_hdf5 and test_pickle)CouplingModel.add_coupling
arguments