Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2020-01-07 tc120 M3SS missing DOSE2U definition causes crash #149

Closed
tensfeldt opened this issue Jan 7, 2020 · 3 comments
Closed

2020-01-07 tc120 M3SS missing DOSE2U definition causes crash #149

tensfeldt opened this issue Jan 7, 2020 · 3 comments
Labels
2.0.1_deferred Deferred for production delivery

Comments

@tensfeldt
Copy link
Owner

tensfeldt commented Jan 7, 2020

tc120 M3SS is based upon B2901001 with 2 defined dosing intervals. However, there's only one DOF/DOFU defined (need to confirm that the DOF defined is used for both intervals and whether a second definition DOF2/DOF2U would be used if indeed incoporated into the MCT, note that output for DOF2 appears in the parameter results) and only one DOSE1/DOSE1U pair defined.

In this case, DOSE2 is assumed to be unit dose, which is expected. However, the run_M3_SS module crashes since DOSE2U is not defined. If DOSE2U is defined, the crash doesn't occur.

Recommend that if DOSE2 is not defined and assume that it will be unit dose, the associated DOSE2U lack of definition not cause a crash. Permit this to be missing.

tc120 files will be added to onedrive for testing.

@tensfeldt tensfeldt added the 2.0.1_deferred Deferred for production delivery label Jan 21, 2020
@TomTensfeldt TomTensfeldt added this to the 2.0.1_high_priority milestone Apr 4, 2020
opennca added a commit that referenced this issue May 2, 2020
- Fixed Issues with missing DOSE2U that caused crashed with LASTTIME for M3SS (Issue #149)
- Fixed Issues with LASTTIME for BLQ/LLOQ concentration values (Issue #195)
- Accounted for BLQ/LLOQ values for LASTTIME/LASTTIMEi for M1SD, M1SS, M2SD, M2SS, M3SD, M3SS
- Fixed Issues with TAUi for M3SS
@jhhughes256
Copy link
Collaborator

Testing with commit ed0aed3 an error still occurs.

> paste(testcase.id, mct$MODEL, mct$DOSINGTYPE, mct$AUCMETHOD, mct$TIME, sep = ".")
[1] "tc120.M3.SS.LINLOG.NOMINAL"
> # pretime <- Sys.time()
> results_list <- run_computation(data = d, map = mct, flag = flags, 
+   parameterset = parameterset)
DOSE2  as defined in 'map', do not appear in input concentration dataset 
assuming unit dose amounts for:  DOSE2 
DOSE2U  as defined in 'map', do not appear in input concentration dataset 
Error in value[[3L]](cond) : 
  Error in `[.data.frame`(data_data, !duplicated(data_data[, xdose]), vlist): undefined columns selected
For SDEID 49420991
In addition: Warning messages:
1: In validate_timeconc_data(map, data, flag, verbose = verbose) :
  assuming unit dose amounts for each dose
2: In validate_timeconc_data(map, data, flag, verbose = verbose) :
  Dosing unit: 'DOSE2U' isn't present in input concentration dataset

3: In doTryCatch(return(expr), name, parentenv, handler) :
  Removing SDEID: '49420991' due to duplicate TIME but different CONC values
4: In doTryCatch(return(expr), name, parentenv, handler) :
  Missing concentration at TAU and/or TOLD for SDEID: '49420991'
5: In doTryCatch(return(expr), name, parentenv, handler) :
 
 Show Traceback
 
 Rerun with Debug
 Error in value[[3L]](cond) : 
  Error in `[.data.frame`(data_data, !duplicated(data_data[, xdose]), vlist): undefined columns selected
For SDEID 49420991 

@jhhughes256
Copy link
Collaborator

This issue has been closed from a scope perspective, but not from a GitHub perspective.

@jhhughes256
Copy link
Collaborator

While not officially in scope, this issue has been addressed due to other fixes with commit 53d87f1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0.1_deferred Deferred for production delivery
Projects
None yet
Development

No branches or pull requests

3 participants