Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forall Context #526

Merged
merged 25 commits into from
Aug 2, 2022
Merged

Forall Context #526

merged 25 commits into from
Aug 2, 2022

Conversation

zhang677
Copy link
Contributor

A new concept "Forall Context" is introduced to solve the "= or +=" choice in workspace. Test "tile_dotProduct_1" is enabled now!

@weiya711 weiya711 self-requested a review June 24, 2022 23:16
@zhang677
Copy link
Contributor Author

zhang677 commented Jul 13, 2022

Update! A new schedule command wsaccel is added to control whether the workspace acceleration is used and to assign which dimensions the workspace acceleration is used. Test "tile_dotProduct_2" is enabled now!

Copy link
Contributor

@weiya711 weiya711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added review comments that should be fixed before merging

include/taco/index_notation/index_notation.h Outdated Show resolved Hide resolved
include/taco/index_notation/index_notation.h Show resolved Hide resolved
include/taco/index_notation/index_notation.h Show resolved Hide resolved
src/index_notation/index_notation.cpp Outdated Show resolved Hide resolved
src/index_notation/index_notation.cpp Outdated Show resolved Hide resolved
src/index_notation/index_notation.cpp Outdated Show resolved Hide resolved
src/index_notation/index_notation.cpp Outdated Show resolved Hide resolved
test/tests-scheduling-eval.cpp Outdated Show resolved Hide resolved
test/tests-workspaces.cpp Show resolved Hide resolved
const std::vector<IndexVar>& getaccelIndexVars() const;

/// Gets the acceleration flag
bool getshouldAccel() const;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getShouldAccel and setAccelIndexVars should be capitalized as shown

@weiya711 weiya711 merged commit 2b8ece4 into tensor-compiler:master Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants