fix: panic if daemon command is invalid (#788)

* fix: panic if daemon command is invalid

Signed-off-by: Keming <kemingyang@tensorchord.ai>

* Update pkg/lang/frontend/starlark/runtime/runtime.go

Co-authored-by: Ce Gao <ce.gao@outlook.com>
Signed-off-by: Keming <kemingy94@gmail.com>

* fix errorf

Signed-off-by: Keming <kemingyang@tensorchord.ai>

* fix import but not used

Signed-off-by: Keming <kemingyang@tensorchord.ai>

Signed-off-by: Keming <kemingyang@tensorchord.ai>
Signed-off-by: Keming <kemingy94@gmail.com>
Co-authored-by: Ce Gao <ce.gao@outlook.com>

pkg/lang/frontend/starlark/runtime/runtime.go

@@ -15,9 +15,7 @@
 package runtime
 
 import (
-	"errors"
-	"fmt"
-
+	"github.com/cockroachdb/errors"
 	"github.com/sirupsen/logrus"
 	"go.starlark.net/starlark"
 	"go.starlark.net/starlarkstruct"
@@ -51,7 +49,7 @@ func ruleFuncCommand(thread *starlark.Thread, _ *starlark.Builtin,
 	commandsMap := make(map[string]string)
 	for _, tuple := range commands.Items() {
 		if len(tuple) != 2 {
-			return nil, fmt.Errorf("invalid command in %s", ruleCommand)
+			return nil, errors.Newf("invalid command in %s", ruleCommand)
 		}
 
 		commandsMap[tuple[0].(starlark.String).GoString()] =
@@ -78,8 +76,7 @@ func ruleFuncDaemon(thread *starlark.Thread, _ *starlark.Builtin,
 		for i := 0; i < commands.Len(); i++ {
 			args, ok := commands.Index(i).(*starlark.List)
 			if !ok {
-				logger.Warnf("cannot parse %s into a list of string", commands.Index(i).String())
-				continue
+				return nil, errors.Newf("invalid daemon commands (%s)", commands.Index(i).String())
 			}
 			argList := []string{}
 			for j := 0; j < args.Len(); j++ {
@@ -132,7 +129,7 @@ func ruleFuncEnviron(thread *starlark.Thread, _ *starlark.Builtin,
 	envMap := make(map[string]string)
 	for _, tuple := range env.Items() {
 		if len(tuple) != 2 {
-			return nil, fmt.Errorf("invalid env (%s)", tuple.String())
+			return nil, errors.Newf("invalid env (%s)", tuple.String())
 		}
 
 		envMap[tuple[0].(starlark.String).GoString()] = tuple[1].(starlark.String).GoString()