Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable convenient vscode debugging #1089

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

dragonly
Copy link
Contributor

With this PR, we can debug a binary built with make debug-local in vscode easily.

image

Signed-off-by: Yilong Li <liyilongko@gmail.com>
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
/lgtm

@muniu-bot muniu-bot bot added the lgtm label Oct 26, 2022
@muniu-bot
Copy link

muniu-bot bot commented Oct 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dragonly, gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@muniu-bot muniu-bot bot added the approved label Oct 26, 2022
@gaocegege gaocegege merged commit 3416e70 into tensorchord:main Oct 26, 2022
@dragonly dragonly deleted the feat/vscode-debug branch October 26, 2022 07:04
@@ -22,6 +22,7 @@ vendor/
go.work

.vscode/*
!.vscode/launch.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have to add this special exclusion but use git add -f to add the file and the result will be expected :)

Copy link
Contributor

@tisonkun tisonkun Oct 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then the index only exists in the git database so other tools may not work XD.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then the index only exists in the git database so other tools may not work XD.

I did not get this. Do you mean the current change is correct, but a more elegant way is to use git add -f? @tisonkun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

3 participants