Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change to dynamic PATH #1375

Merged
merged 5 commits into from
Jan 4, 2023
Merged

fix: change to dynamic PATH #1375

merged 5 commits into from
Jan 4, 2023

Conversation

kemingy
Copy link
Member

@kemingy kemingy commented Jan 3, 2023 •
edited
Loading

Usage

  • runtime env
  • build time path
    • init
    • renew when switch the user

Design

  • maintain it in the Graph (RuntimeEnvPaths)
  • init as the system PATH
  • update if needed

Note: runtime env PATH leaks to build time

@kemingy
change to dynamic path
04014ee 
Signed-off-by: Keming <kemingy94@gmail.com>
@kemingy
rm debug log
b3ee066 
Signed-off-by: Keming <kemingy94@gmail.com>
@kemingy
fix lint
5c0a1d3 
Signed-off-by: Keming <kemingy94@gmail.com>
gaocegege
gaocegege reviewed Jan 3, 2023
View reviewed changes
pkg/lang/ir/v1/system.go Outdated Show resolved Hide resolved
pkg/lang/ir/v0/system.go Outdated Show resolved Hide resolved
pkg/lang/ir/v1/julia.go Outdated Show resolved Hide resolved
kemingy and others added 2 commits January 3, 2023 21:10
@kemingy @gaocegege
Update pkg/lang/ir/v1/julia.go
8211e1b 
Co-authored-by: Ce Gao <ce.gao@outlook.com>
Signed-off-by: Keming <kemingy94@gmail.com>
@kemingy
address commment
5ff1baf 
Signed-off-by: Keming <kemingy94@gmail.com>
gaocegege
gaocegege approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
/lgtm

@muniu-bot muniu-bot bot added the lgtm label Jan 4, 2023
@gaocegege gaocegege merged commit 754b6c3 into tensorchord:main Jan 4, 2023
@kemingy kemingy deleted the env_path branch January 4, 2023 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege approved these changes

@aseaday aseaday Awaiting requested review from aseaday aseaday is a code owner

@zwpaper zwpaper Awaiting requested review from zwpaper zwpaper is a code owner

Assignees

@gaocegege gaocegege

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: DefaultPathEnvUnix should be dynamic
2 participants
@kemingy @gaocegege