Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the logic of adding entry in wsl #1414

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Conversation

hwdef
Copy link
Member

@hwdef hwdef commented Jan 13, 2023

Fix: #1269

@muniu-bot
Copy link

muniu-bot bot commented Jan 13, 2023

Welcome @hwdef! It looks like this is your first PR to tensorchord/envd 🎉

Signed-off-by: hwdef <hwdefcom@outlook.com>
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
/lgtm

@muniu-bot muniu-bot bot added the lgtm label Jan 13, 2023
@gaocegege
Copy link
Member

/assign @VoVAllen

@muniu-bot
Copy link

muniu-bot bot commented Jan 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, hwdef

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

2 similar comments
@muniu-bot
Copy link

muniu-bot bot commented Jan 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, hwdef

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@muniu-bot
Copy link

muniu-bot bot commented Jan 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, hwdef

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hwdef
Copy link
Member Author

hwdef commented Jan 13, 2023

By the way, I checked the method of judging whether it is wsl, and I feel that there may be some problems. Azure has a linux system maintained by Microsoft, which may cause problems in judging

@gaocegege
Copy link
Member

By the way, I checked the method of judging whether it is wsl, and I feel that there may be some problems. Azure has a linux system maintained by Microsoft, which may cause problems in judging

Could you please open an issue to keep track of it?

@hwdef
Copy link
Member Author

hwdef commented Jan 13, 2023

By the way, I checked the method of judging whether it is wsl, and I feel that there may be some problems. Azure has a linux system maintained by Microsoft, which may cause problems in judging

Could you please open an issue to keep track of it?

I will try to install this OS, If the problem does exist, I will create the issue.

Copy link
Member

@VoVAllen VoVAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm Thanks for your contribution!

@VoVAllen VoVAllen merged commit 64b5a0a into tensorchord:main Jan 13, 2023
@gaocegege
Copy link
Member

@all-contributors Please add @hwdef for the code contribution!

@allcontributors
Copy link
Contributor

@gaocegege

I've put up a pull request to add @hwdef! 🎉

@hwdef hwdef deleted the 1269 branch January 13, 2023 08:33
@hwdef
Copy link
Member Author

hwdef commented Jan 13, 2023

image

I installed CBL-Mariner
And checked the content of /proc/version, there is no microsoftcharacters in it, so the method we use to check whether it is wsl is feasible. No need to modify anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Running Envd inside WSL2 tried to edit the file on host machine
3 participants