Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default python in the base image #1589

Merged
merged 4 commits into from
May 5, 2023
Merged

Use default python in the base image #1589

merged 4 commits into from
May 5, 2023

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented May 3, 2023

  • Use default python in the base image
  • Allow users to install Python packages even if they didn't specify install.python.

@pingsutw
use default python in the base image
60f8af5 
Signed-off-by: Kevin Su <pingsutw@apache.org>
@pingsutw
nit
de91a53 
Signed-off-by: Kevin Su <pingsutw@apache.org>
@pingsutw
lint fix
9560ba5 
Signed-off-by: Kevin Su <pingsutw@apache.org>
gaocegege
gaocegege previously approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/cc @kemingy

@gaocegege gaocegege requested a review from kemingy May 3, 2023 09:40
@pingsutw
nit
0e24aff 
Signed-off-by: Kevin Su <pingsutw@apache.org>
@kemingy kemingy added this pull request to the merge queue May 5, 2023
Merged via the queue into tensorchord:main with commit 0a55acd May 5, 2023
14 checks passed
@pingsutw
Copy link
Member Author

pingsutw commented May 5, 2023

@gaocegege @kemingy could we cut a release for it?

@kemingy
Copy link
Member

kemingy commented May 6, 2023

@gaocegege @kemingy could we cut a release for it?

v0.3.21 has been released https://github.com/tensorchord/envd/releases/tag/v0.3.21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kemingy kemingy kemingy approved these changes

@gaocegege gaocegege gaocegege left review comments

@aseaday aseaday Awaiting requested review from aseaday aseaday is a code owner

@zwpaper zwpaper Awaiting requested review from zwpaper zwpaper is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pingsutw @kemingy @gaocegege