support using json for registry config #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Li <ricli@linkedin.com>
kemingy
reviewed
Jul 3, 2023
Signed-off-by: Richard Li <ricli@linkedin.com>
|
Hi is it ready for another review? |
|
Yes sorry, I'm new to Github and open source. In general if I make a change, how do I notify reviewers? Just leave a comment? |
You can click the "re-request review" on the top right reviewers' list. Leaving a comment is also okay. |
kemingy
reviewed
Jul 4, 2023
Co-authored-by: Keming <kemingy94@gmail.com> Signed-off-by: Richard Li <98242479+RichhLi@users.noreply.github.com>
kemingy
approved these changes
Jul 4, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
envd bootstrap --registry-config path_to_json_fileFormat:
Note that the "name" field is required. The other fields are all optional.
This will allow users to specify private Docker registries and the respective credentials. Under the hood, we parse these credentials and create a corresponding buildkit TOML file, as well as set up Docker bindings. This enables users to pull and push images from private Docker registries.
This is also completely backwards compatible with the existing "registry" and "registry-ca-keypair" command. We check that a user only specifies "registy-config" on its own, meaning that a user can't use both registry-config and registry or both registry-config and registry-ca-keypair.
The registry-config command also enables users to specify more than one registry now. For example, if the registry you pull your image from is different than the registry you push your image to, and you need auth for both of them, you should use the registry-config command.