Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add envd app exit handler #1722

Merged
merged 4 commits into from
Aug 4, 2023
Merged

Conversation

kemingy
Copy link
Member

@kemingy kemingy commented Aug 4, 2023

I just found that the default urfave/cli error handler cannot print the full error backtrace messages.

Before:

error: invalid reference format

After:

FATA[2023-08-04T16:25:13+08:00] failed to parse the build options: failed to parse the name '_dir:dev', please provide a valid image name: invalid reference format

Signed-off-by: Keming <kemingyang@tensorchord.ai>
gaocegege
gaocegege previously approved these changes Aug 4, 2023
Signed-off-by: Keming <kemingyang@tensorchord.ai>
Signed-off-by: Keming <kemingyang@tensorchord.ai>
@kemingy kemingy added this pull request to the merge queue Aug 4, 2023
Merged via the queue into tensorchord:main with commit f51990e Aug 4, 2023
15 checks passed
@kemingy kemingy deleted the app_exit_handler branch August 4, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ERROR exporting to oci image format when the first character of directory name is underline
2 participants