Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Suport conda env #335

Merged
merged 3 commits into from
Jun 14, 2022
Merged

feat: Suport conda env #335

merged 3 commits into from
Jun 14, 2022

Conversation

gaocegege
Copy link
Member

Fix #332

Signed-off-by: Ce Gao cegao@tensorchord.ai

Signed-off-by: Ce Gao <cegao@tensorchord.ai>
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
@gaocegege gaocegege requested a review from VoVAllen June 14, 2022 12:37
@gaocegege gaocegege changed the title feat: Suport conda env WIP feat: Suport conda env Jun 14, 2022
@gaocegege
Copy link
Member Author

In this PR we do not use the conda base environment. We will create an environment envd, and install the python version specified in base.

Signed-off-by: Ce Gao <cegao@tensorchord.ai>
Copy link
Member

@VoVAllen VoVAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The channel part is a bit ugly. We might want to provide utils that can directly read from files.

@gaocegege gaocegege merged commit 7d577f7 into tensorchord:main Jun 14, 2022
@gaocegege gaocegege deleted the conda-envd branch June 14, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

feat(lang): Change conda python version in build.envd
2 participants