Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CLI): Add '--detail' for detail version information (#283) #471

Merged
merged 3 commits into from
Jun 20, 2022

Conversation

popfido
Copy link
Member

@popfido popfido commented Jun 20, 2022

What does this PR do?

  • Add extra doctor information in version by --detail

fix #283

Does your PR introduce any breaking changes? If yes, please list them.

No.

Before submitting

  • Was this discussed/approved via a issue? (not for typos and docs)
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did your make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?

Signed-off-by: Popfido wanghailin317@gmail.com

Signed-off-by: Popfido <wanghailin317@gmail.com>
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for your contribution! 🎉 👍

@gaocegege
Copy link
Member

Please run go mod tidy to update the go dependencies.

Signed-off-by: Popfido <wanghailin317@gmail.com>
@popfido
Copy link
Member Author

popfido commented Jun 20, 2022

Please run go mod tidy to update the go dependencies.

@gaocegege Done

@popfido
Copy link
Member Author

popfido commented Jun 20, 2022

cc: @gaocegege . Don't know whether the failure in CI/lint need to be fixed.

@popfido popfido changed the title Feat: Add '--detail' for detail version information feat(CLI): Add '--detail' for detail version information #283 Jun 20, 2022
@popfido popfido changed the title feat(CLI): Add '--detail' for detail version information #283 feat(CLI): Add '--detail' for detail version information (#283) Jun 20, 2022
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the update, please rerun go mod tidy again.

The command go mod tidy will update the dependencies (In our case, it will remove github.com/pkg/errors in go.mod)

pkg/version/version.go Outdated Show resolved Hide resolved
pkg/version/version.go Outdated Show resolved Hide resolved
Signed-off-by: Popfido <wanghailin317@gmail.com>
@gaocegege gaocegege merged commit 229821a into tensorchord:main Jun 20, 2022
@gaocegege
Copy link
Member

Thanks for your contribution! 🎉 👍

@gaocegege
Copy link
Member

Please add @popfido for the code contribution. @all-contributors

@gaocegege
Copy link
Member

@all-contributors Please add @popfido for the code contribution

@allcontributors
Copy link
Contributor

@gaocegege

I've put up a pull request to add @popfido! 🎉

@popfido popfido deleted the feat/version_detail branch June 20, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

feat(CLI): envd doctor command
2 participants