Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build.go #472

Merged
merged 3 commits into from
Jun 20, 2022
Merged

Update build.go #472

merged 3 commits into from
Jun 20, 2022

Conversation

Gui-Yue
Copy link
Member

@Gui-Yue Gui-Yue commented Jun 20, 2022

(default: PROJECT:dev) can be removed if we use DefaultText

@gaocegege
Copy link
Member

Hi you can run

make fmt
git add .
git commit -m "chore: Update format"
git push

to fix the CI lint issues.

@Gui-Yue
Copy link
Member Author

Gui-Yue commented Jun 20, 2022

I am doing that now

@Gui-Yue
Copy link
Member Author

Gui-Yue commented Jun 20, 2022

Thanks for your help, I am a tiro.

@gaocegege
Copy link
Member

gaocegege commented Jun 20, 2022

No worry about it. I was also unfamiliar with how to contribute before. Feel free to at me @gaocegege to review if the PR is ready!

@gaocegege gaocegege mentioned this pull request Jun 20, 2022
@Gui-Yue
Copy link
Member Author

Gui-Yue commented Jun 20, 2022

I am sorry to disturb that i meet one new problem. how do i solve it using the command of "make fmt" ,the process stuck.the last line is:go: downloading golang.org/x/term v0.0.0-20210927222741-03fcf44c2211 @gaocegege

@gaocegege
Copy link
Member

It means that golang tries to download the dependencies. And I guess you are in China, just like me. I recommend:

export GOPROXY=https://goproxy.io,direct
make fmt

The environment variable GOPROXY sets the golang cache mirror which can accelerate the process.

@gaocegege
Copy link
Member

I am sorry to disturb that

You are always welcome.

@Gui-Yue
Copy link
Member Author

Gui-Yue commented Jun 20, 2022

I know that.I resolved this problem successfully!

@gaocegege
Copy link
Member

LGTM 👍
/lgtm

@gaocegege gaocegege merged commit ff43aa3 into tensorchord:main Jun 20, 2022
@Gui-Yue
Copy link
Member Author

Gui-Yue commented Jun 20, 2022

Thanks for your help for me! You are so kind!

@gaocegege
Copy link
Member

@all-contributors Please add @Gui-Yue for the code contribution.

Welcome to open source.

@allcontributors
Copy link
Contributor

@gaocegege

I've put up a pull request to add @Gui-Yue! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants