Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typo and format imports and simplify code #500

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

hezhizhen
Copy link
Contributor

Signed-off-by: Zhizhen He hezhizhen.yi@gmail.com

Signed-off-by: Zhizhen He <hezhizhen.yi@gmail.com>
@hezhizhen
Copy link
Contributor Author

Sorry to make it a large PR, but all the changes are trivial, and I've checked every change on GitHub manually. Please take a look at it.

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gaocegege
Copy link
Member

@hezhizhen I am wondering if the cli is removed by gofmt?

@gaocegege
Copy link
Member

@all-contributors Please add @hezhizhen for doc contribution.

@allcontributors
Copy link
Contributor

@gaocegege

I've put up a pull request to add @hezhizhen! 🎉

@hezhizhen
Copy link
Contributor Author

@hezhizhen I am wondering if the cli is removed by gofmt?

I use GoLand which has an option about imports called Remove redundant import aliases and every time I save Go files, they will be formatted and redundant import aliases will be removed.

@gaocegege
Copy link
Member

OK SGTM.

The alias is actually auto-added by vscode golang extension 😄

@gaocegege gaocegege merged commit 4ff314e into tensorchord:main Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants