feat: replace IsCreated with Exists for Client interface from package docker #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… docker Signed-off-by: zhyon404 <zhyong4@gmail.com>
|
Thanks for your contribution! 🎉 👍 |
|
This PR fixes #478 |
|
@all-contributors Please add @zhyon404 for code contribution. |
|
I've put up a pull request to add @zhyon404! 🎉 |
hezhizhen
reviewed
Jul 6, 2022
| @@ -59,7 +59,7 @@ type Client interface { | |||
| StartBuildkitd(ctx context.Context, tag, name, mirror string) (string, error) | |||
|
|
|||
| IsRunning(ctx context.Context, name string) (bool, error) | |||
| IsCreated(ctx context.Context, name string) (bool, error) | |||
There was a problem hiding this comment.
It's better to add a new method Exists and mark IsCreated deprecated.
There was a problem hiding this comment.
We are still in alpha, thus I think it also works although we remove it directly.
There is no project that relies on us, currently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #478