feat: Support for build image update when exec build or up again #570
Conversation
Signed-off-by: Qi Chen <aseaday@hotmail.com>
|
It is not a formal PR but for your own exp. I found some problems when check updates between image and manifest files. We could only accept this problem or we introduce a hash of the manifest and label it on the image: Hash(manifest.AST + pubkey + config_file) |
| @@ -120,7 +120,50 @@ func (b generalBuilder) NumGPUs() int { | |||
| return ir.NumGPUs() | |||
| } | |||
|
|
|||
| // Always return updated when met error | |||
| func (b generalBuilder) CheckDepsFileUpdate(ctx context.Context, tag string, deps []string) (bool, error) { | |||
There was a problem hiding this comment.
Fancy implementation!
I am not sure how docker deals with the ImageCreateTime in our case. Did you test the logic locally?
There was a problem hiding this comment.
I test it. It seems that depends the tarball from the buildkit. So it could be cached if llb didn't change.
| func (b generalBuilder) Build(ctx context.Context, pub string) error { | ||
| depsFiles := []string{ | ||
| pub, |
There was a problem hiding this comment.
I am not sure what pub is, could you please explain more about it?
There was a problem hiding this comment.
The pub key is filepath "/home/aseaday/.config/envd/id_rsa_envd.pub". I think It can be changed if users bootstrap again. So it need to be added into depsFiles.
Maybe we should document it in envd docs. |
Signed-off-by: Qi Chen aseaday@hotmail.com