Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: image tag normalized to docker spec #573

Merged
merged 1 commit into from
Jul 8, 2022
Merged

Fix: image tag normalized to docker spec #573

merged 1 commit into from
Jul 8, 2022

Conversation

aseaday
Copy link
Member

@aseaday aseaday commented Jul 8, 2022 •
edited
Loading

Signed-off-by: Qi Chen aseaday@hotmail.com

  • rename the image tag do lowcased if reference has some uppers
  • throw error if the directory just a digest [a-z0-9]{64}

@aseaday
Fix: image tag normalized to docker spec
0f39b32 
Signed-off-by: Qi Chen <aseaday@hotmail.com>
@aseaday
Copy link
Member Author

aseaday commented Jul 8, 2022

#572

@aseaday aseaday requested a review from gaocegege July 8, 2022 06:50
gaocegege
gaocegege approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🎉 👍

Especially for the test!

gaocegege
gaocegege approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🎉 👍

Especially for the test!

@gaocegege
Copy link
Member

/cc @kemingy

@gaocegege gaocegege merged commit 8f89e4b into tensorchord:main Jul 8, 2022
@aseaday aseaday deleted the fix/lower_case_repo branch July 12, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
envd sprint board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aseaday @gaocegege