New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Improve error wrapping and checking #590

Merged

gaocegege merged 1 commit into tensorchord:main from terrytangyuan:error-wrap

Jul 12, 2022

Member

terrytangyuan commented Jul 11, 2022

This fixes the following error lint checks:

comparing with == will fail on wrapped errors. Use errors.Is to check for a specific error
type assertion on error will fail on wrapped errors. Use errors.As to check for specific errors

Signed-off-by: Yuan Tang terrytangyuan@gmail.com


          chore: Improve error wrapping and checking

73b4efc

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

gaocegege approved these changes

View reviewed changes

Member

gaocegege left a comment

LGTM!

gaocegege merged commit a84af3a into tensorchord:main

terrytangyuan deleted the error-wrap branch

July 12, 2022 00:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment