feat: informative error message #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VoVAllen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Jinjing.Zhou <allenzhou@tensorchord.ai>
VoVAllen
changed the title
VoVAllen
commented
Sep 16, 2022
There was a problem hiding this comment.
Found error trace is not informative in most cases. Finally decide not to add it. Only debug mode will print the full error stacktrace.
Other changes:
- For buildkit error, it will print the full error trace for user easier to understand the detailed error
- Starlark list -> String slice will panic before if element is not string inside the list. Now check before conversion
gaocegege
reviewed
Sep 16, 2022
| @@ -280,7 +290,8 @@ func (b generalBuilder) build(ctx context.Context, pw progresswriter.Writer) err | |||
| } | |||
| _, err := b.Client.Build(ctx, solveOpt, "envd", b.BuildFunc(), pw.Status()) | |||
| if err != nil { | |||
| err = errors.Wrap(err, "failed to solve LLB") | |||
| err = errors.Wrap(&BuildkitdErr{err: err}, "Buildkit error") | |||
| logrus.Errorf("%+v", err) | |||
There was a problem hiding this comment.
This is intentional. %+v is a feature of cockroachdb/errors to print the full error messages including stacktrace.
| if ok := errors.As(err, &evalErr); ok { | ||
| fmt.Fprintln(os.Stderr, evalErr.Backtrace()) | ||
| } else if ok := errors.As(err, &syntaxErr); ok { | ||
| fmt.Fprintln(os.Stderr, syntaxErr) | ||
| } else if ok := errors.As(err, &resolveErr); ok { | ||
| fmt.Fprintf(os.Stderr, "%+v\n", resolveErr) |
Signed-off-by: Jinjing.Zhou <allenzhou@tensorchord.ai>
|
LGTM /cc @kemingy |
|
/LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jinjing.Zhou allenzhou@tensorchord.ai