Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: shell exit with set -euo pipefail #879

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

kemingy
Copy link
Member

@kemingy kemingy commented Sep 12, 2022

Signed-off-by: Keming kemingyang@tensorchord.ai

Signed-off-by: Keming <kemingyang@tensorchord.ai>
@muniu-bot
Copy link

muniu-bot bot commented Sep 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kemingy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@muniu-bot muniu-bot bot added the approved label Sep 12, 2022
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@muniu-bot muniu-bot bot added the lgtm label Sep 13, 2022
@muniu-bot muniu-bot bot merged commit 918fe3f into tensorchord:main Sep 13, 2022
@kemingy kemingy deleted the chore_set_sh_exit branch September 13, 2022 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants