New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix types in ChatCompletionRequest.get_prompt() #24

Merged

kemingy merged 1 commit into tensorchord:main from tddschn:fix-types-20230523

May 23, 2023

Contributor

tddschn commented May 23, 2023

rename the variable assigned the LanguageModels.find() to language_model from model.

model is declared as str in the arg, and editors will complain if model's type changes in the function body.


          Fix types in ChatCompletionRequest.get_prompt()

5ccb747

tddschn requested a review from kemingy

May 23, 2023 05:09

kemingy approved these changes

View reviewed changes

kemingy merged commit 06e480d into tensorchord:main

13 of 14 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment